search

stormpath / stormpath-django

Django plugin for Stormpath
Apache License 2.0
38 stars 19 forks source link

Bug fixes #19

Closed skolsuper closed 9 years ago

skolsuper commented 9 years ago

Fixes incompatible arguments being passed from django-rest-framework-jwt to StormpathBackend.authenticate, and changed unexpected behavious (no return value) of StormpathUserManager.create

denibertovic commented 9 years ago

Hi @skolsuper, just a small nitpick, can you update the PR with this small change:

def authenticate(self, username=None, password=None, **kwargs):
    if username is None:
        username = kwargs.get(UserModel.USERNAME_FIELD)
    ....
skolsuper commented 9 years ago

No problem

denibertovic commented 9 years ago

@skolsuper awesome tnx! :+1: @rdegges this looks ready for merge.

rdegges commented 9 years ago

Thanks @skolsuper for the codez <333

I just pushed a new release to PyPI (0.0.4) with these fixes included. You're also in the changelog! https://github.com/stormpath/stormpath-django#version-004