stormpath / stormpath-framework-tck

HTTP integration tests that ensure a Stormpath web framework integration implements the Stormpath Framework Specification
Apache License 2.0
11 stars 5 forks source link

Check for status code on MeIT #297

Closed DamirSvrtan closed 8 years ago

DamirSvrtan commented 8 years ago

I had a 500 error but the TCK only reported that the response doesn't have an account href property. If it had a check for the status code before that I would have managed to do a quicker fix on my side.

Hope this helps others :)

edjiang commented 8 years ago

It should actually already be checking for 200, since it's using the AccountResponseSpec:

https://github.com/stormpath/stormpath-framework-tck/blob/master/src/test/groovy/com/stormpath/tck/responseSpecs/AccountResponseSpec.groovy

Not sure what order RestAssured does these assertions but the thing you submitted is probably not the right approach.

edjiang commented 8 years ago

Closing since I haven't seen a response for this in a bit. Feel free to reopen if you want to discuss further.

DamirSvrtan commented 8 years ago

Sorry @edjiang, as you said, I'm also not sure how RestAssured orders them, the only thing I would modify is the order if that's a possibility. I'm okay with closing this.

edjiang commented 8 years ago

If you want to open up an issue; I think better diagnoses of RestAssured errors are always nice to have =]