search

stormpath / stormpath-laravel

Build simple, secure web applications with Stormpath and Laravel
Other
29 stars 6 forks source link

Add Laravel Event firing #26

Closed kryten87 closed 8 years ago

kryten87 commented 8 years ago

Here's some work I did on event firing for important Stormpath-related actions, as discussed in issue #24.

I've included documentation - see docs/events.rst - and tests. However, I'm fairly new to testing & still learning, so please let me know if you feel my tests are not adequate.

codecov-io commented 8 years ago

Current coverage is 99.38%

Merging #26 into develop will not affect coverage as of 56e1f0c

@@            develop     #26   diff @@
=======================================
  Files            11      11       
  Stmts           646     646       
  Branches          0       0       
  Methods          49      49       
=======================================
  Hit             642     642       
  Partial           0       0       
  Missed            4       4

Review entire Coverage Diff as of 56e1f0c

Powered by Codecov. Updated on successful CI builds.

bretterer commented 8 years ago

Thanks for the PR. I will put this in our action list to take a look at ASAP.

I will keep you updated!

bretterer commented 8 years ago

Thank you @Kryten0807 for this pull request. Everything looked great. I will made some modifications to the tests to get a little more coverage, but this is a great addition to the integration! I went ahead and added you to the contribution page in the docs. I used your github username and url for the link. Please feel free to add any other information here that you would like to see.

kryten87 commented 8 years ago

Thanks for this! And now that you've merged this, I have another pull request for you (#30), addressing issue #26 :-)