stormpath / stormpath-sdk-angularjs

User Management for AngularJS (1.x) applications
http://docs.stormpath.com/angularjs/sdk/
Apache License 2.0
165 stars 58 forks source link

Finish LinkedIn implementation #122

Open robertjd opened 8 years ago

robertjd commented 8 years ago

The service boilerplate is there, but we need to finish it and use express-stormpath to handle the OAuth callback.

bartzilla commented 7 years ago

Hi @rbhojan,

I was trying to use the sdk preconfigured login template (sp-login-form) with linkedIn and Github. However, the social buttons are not rendered. Seems likeaccountStore in login template is empty, even when I properly created the apps and configured the directories in my app.

login template line 55 <button ng-repeat="accountStore in viewModel.accountStores" type="button" class="btn btn-social btn-{{accountStore.provider.providerId}}" sp-social-login="{{accountStore.provider.providerId}}" sp-client-id="{{accountStore.provider.clientId}}" sp-scope="{{accountStore.provider.scope}}"> {{providerName}} </button>

If I use Facebook login the button gets rendered and it all works fine. I followed this tutorial is it currently possible to use out of the box github & linkedin logins using the stormpath-sdk-angularjs?

robertjd commented 7 years ago

Hi @bartzilla - Unfortunately we aren't yet rendering the linkedin buttons in this library, it looks like I created this issue to track that :) I'll open this issue for work, but we have some other priorities for the next several weeks. In the meantime, could you use the default login page the our express-stormpath library provides? That one should be working with Linkedin login.

bartzilla commented 7 years ago

Ok, thanks for the prompt response @robertjd. was just wondering if perhaps this issue and what is currently implemented were out of sync.

robertjd commented 7 years ago

I'm going to bump this to the backlog for now, until our new Social API is available