search

stormpath / stormpath-sdk-angularjs

User Management for AngularJS (1.x) applications
http://docs.stormpath.com/angularjs/sdk/
Apache License 2.0
165 stars 58 forks source link

Add typescript declaration file #198

Open gomoto opened 7 years ago

gomoto commented 7 years ago

This pull request adds a TypeScript declaration file. TypeScript users will automatically get type information without separately installing types using typings or npm. TypeScript suggests bundling types with an npm package.

robertjd commented 7 years ago

Thans @gomoto ! Is this something that was auto-generated, or did you have to write it manually? @mraible could you take a look at this with your IDE?

gomoto commented 7 years ago

Wrote it manually based on the documentation, and tried to emulate the type declarations for existing angular modules like angular-animate.

mraible commented 7 years ago

From my Java development experience, I try to stay away from "I" prefixes for interfaces. Can you change this PR to remove them? Also, what's the use case for this change? Are you developing an Angular 1.x app with TypeScript?