Tests broken following guide

schinkowitch commented 9 years ago

Following the guide here: http://docs.stormpath.com/angularjs/guide/configure_angular.html

After performing the step: Add Stormpath to the Angular Application, the client tests (grunt test:client) fail with the error:

PhantomJS 1.9.8 (Mac OS X 0.0.0) Controller: MainCtrl should attach a list of things to the scope FAILED Error: [$injector:modulerr] Failed to instantiate module dashboardApp due to: Error: [$injector:modulerr] Failed to instantiate module stormpath.templates due to: Error: [$injector:nomod] Module 'stormpath.templates' is not available! You either misspelled the module name or forgot to load it. If registering a module ensure that you specify the dependencies as the second argument. http://errors.angularjs.org/1.4.0/$injector/nomod?p0=stormpath.templates

I tried explicitly adding 'client/bower_components/stormpath-sdk-angularjs/dist/stormpath-sdk-angularjs.js', 'client/bower_components/stormpath-sdk-angularjs/dist/stormpath-sdk-angularjs.tpls.js', to files in karma.conf.js but then I get the error: PhantomJS 1.9.8 (Mac OS X 0.0.0) Controller: MainCtrl should attach a list of things to the scope FAILED TypeError: 'undefined' is not a function (evaluating 'encoder.encode.bind(encoder)') at FormEncoderService (/Users/aaron/Development/test-1/client/bower_components/stormpath-sdk-angularjs/dist/stormpath-sdk-angularjs.js:1095) at formEncoderServiceFactory (/Users/aaron/Development/test-1/client/bower_components/stormpath-sdk-angularjs/dist/stormpath-sdk-angularjs.js:1196)

drpalaric commented 9 years ago

I've tried to reproduce the error, but couldn't. Try running bower install --save stormpath-sdk-angularjs again. There might have been an issue when you were downloading from bower. Also, there might be more to the stack trace than what you are finding, and adding files manually won't solve the issue. Since you're not too far head in the tutorial, I'd simply try to go through the instructions and install the dependencies again.

schinkowitch commented 9 years ago

I started the tutorial from scratch, and followed the steps carefully. After performing the step: Add Stormpath to the Angular Application, the client tests still fail when executed from the command line (grunt test:client) .

Here is the error with the full stack trace:

drpalaric commented 9 years ago

Yes, I got the same error running grunt test:client, but I think this error has to do with Angular-Fullstack and not Stormpath. Have you tried simply running grunt serve? That should work.

schinkowitch commented 9 years ago

Yes, grunt serve works fine. The point is I'm evaluating using Stormpath for a production app and I need to write testable code. I would think this would be important for you all as well.

I've played around with this some more and found that the following steps seem to fix the issue: 1) add 'client/bower_components/stormpath-sdk-angularjs/dist/stormpath-sdk-angularjs.js', 'client/bower_components/stormpath-sdk-angularjs/dist/stormpath-sdk-angularjs.tpls.min.js', to the files in karma.conf.js

2) Use Chrome instead of PhantomJS for the browser: browsers: ['Chrome'], in karma.conf.js

Then you get a more reasonable test failure: Error: Unexpected request: GET /api/users/current Expected GET /api/things

The stormpath-sdk-angular.js uses ES5.1 Function.prototype.bind which doesn't seem to be implemented in PhantomJS. (This is unfortunate when you recommend angular-fullstack and it is the default test browser).

drpalaric commented 9 years ago

Disclaimer: I don't work for Stormpath and I am a pretty new developer.

Anyway, what you stated about including all the libraries into Karma, is apparently what you need to do to get the tests working initially.

For the second issue, the error seems to be coming from trying to get the route /api/things, but /api/users/current (from stormpath-sdk-express) is getting in the way. Both are called when you get to the front page, and both are called when you log in. Anyway, I think that there might be an issue with the test itself, and looking at the tests for the other controllers, you'll see that they are very generic.

robertjd commented 9 years ago

Hi @schinkowitch , thank you for reporting this. At the moment we don't have a recommendation for a testing framework, so take anything you see created by Angular-Fullstack is merely an example. Please note that this module is still beta.

Perhaps you could use the ES5 shim with Phantom?

Regarding the 'Unexpected request' error, I believe that is coming from Angular's mock $http service

Hopefully these comments help, In lieu of formal instructions for testing.

schinkowitch commented 9 years ago

Ok, thanks. Using the ES5 shim with PhantomJS will probably work. I got the test to run on PhantomJS by using Mozilla's Polyfill here.

The "Error: Unexpected request: GET /api/users/current" test failure is reasonable as the sdk is checking to see if the user is logged in. It's a one line fix in the test.

kevin212 commented 9 years ago

Hi @schinkowitch, what was the "one line fix..." that resolved this issue for you?

As soon as I add stormpath and stormpath.templates as application dependencies, all but a few of my tests fail with that same error: "Error: Unexpected request:".... and it is because SP is checking to see if the user is loogged-in. But my tests are not expecting these calls.

Can you share the one-line fix that worked for you in your tests?

kevin212 commented 9 years ago

Actually, I was able to figure it out:

$httpBackend.expectGET(CURRENT_USER_URI).respond(200, {});

schinkowitch commented 8 years ago

Note: the angular fullstack generator has dropped support for vanilla JS in 3.x, so when following the guide, you need to install the generator with:

npm install -g generator-angular-fullstack@2.1.1

stormpath / stormpath-sdk-angularjs

Tests broken following guide #23