search

stormpath / stormpath-sdk-spec

Language-agnostic API specification for Stormpath SDKs.
2 stars 1 forks source link

connectionTimeout units #13

Closed nbarbettini closed 8 years ago

nbarbettini commented 8 years ago

Is connectionTimeout in the config in seconds, or milliseconds?

In the JSDK, for example, the timeout is specified in milliseconds: https://github.com/stormpath/stormpath-sdk-java/blob/master/api/src/main/java/com/stormpath/sdk/client/ClientBuilder.java#L333

robertjd commented 8 years ago

Honestly I prefer seconds for these kinds of values, as they are simpler to reason with. Is there any reason why a timeout would need a sub-second value?

nbarbettini commented 8 years ago

No reason that I can think of.

lhazlewood commented 8 years ago

It is milliseconds in the Java SDK because this is the idiomatic unit of time in Java when no time unit is specified.

nbarbettini commented 8 years ago

I'm guessing doing the idiomatic thing is the case across all of our implementations. It's probably not crucial to update this spec to standardize it, just slightly confusing when referring back to this.