Support tensorflow 1.5 - Githubissues

stormy-ua / tfModelServing4s

Reasonable API for serving TensorFlow models using Scala

MIT License

31 stars 7 forks source link

Support tensorflow 1.5 #2

Open matanghuy opened 6 years ago

matanghuy commented 6 years ago

Hi, Can you update the library to support tensorflow 1.5?

stormy-ua commented 6 years ago

Hi @matanghuy,

I tested the lib with tensorflow 1.5 and it works for me. Could you share the issue you are seeing with TF version 1.5 ?

I did upgrade tensorflow first:

pip install --upgrade tensorflow

And then I executed Example1:

sbt "project examples" "runMain org.tfModelServing4s.Example1"

It did produce the expected output w/o any errors.

RayTsui commented 5 years ago

Hi @matanghuy @stormy-ua I do not think the lib can work when upgraded, "type TTensor = Tensor" needs to be modified since when upgraded, org.tensorflow.framework Tensor class is generic type and need a type parameter. I have tried that. If something is wrong, please figure out. I will be appreciated so much for that.