search

storpipfugl / pykdtree

Fast kd-tree implementation in Python
GNU Lesser General Public License v3.0
206 stars 48 forks source link

Build against numpy 2.0rc1 #113

Closed djhoese closed 3 months ago

djhoese commented 3 months ago

cibuildwheel doesn't seem to show enough verbosity to know that it is using numpy 2 for building the wheel (it uses 1.26 for testing the wheel and passes). But since the pyproject.toml specifies it I think it is safe.

djhoese commented 3 months ago

As far as I can tell this works. I created a local environment with numpy 2.0.0rc1 and the wheels created by this PR and I can import it. If I install pyresample locally against numpy 2.0.0rc1 and try to import it it fails to import pandas with:

ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject

If you're OK with this @mraspaud then I think this is ready for merge and release.

djhoese commented 3 months ago

FYI @neutrinoceros I moved your Inf commit here, but didn't include the pyproject.toml ones as I like my version better :wink:

djhoese commented 3 months ago

Got approval from Martin on slack...