search

storpipfugl / pykdtree

Fast kd-tree implementation in Python
GNU Lesser General Public License v3.0
215 stars 47 forks source link

stdint.h missing on certain versions of Windows #32

Closed djhoese closed 5 years ago

djhoese commented 6 years ago

I ran in to this issue before when I added appveyor tests to pykdtree. Certain compilers (or versions of those compilers) for Windows do not include some typical C99 headers. To resolve that and not modify pykdtree too much I made appveyor install the missing header files. I didn't think this would still be an issue for most users with modern versions of Windows but we just had a satpy user have difficulty installing pykdtree on his Windows machine because of this.

Perhaps pykdtree could include the headers in the source distribution so that they could be used on a Windows machines (if not present?).

https://github.com/scrapinghub/python-crfsuite/issues/16#issuecomment-82996491

storpipfugl commented 5 years ago

I don't think it would be appropriate for an analysis library to provide system header files as this would be unexpected behavior. The issue is better solved with a small stand alone "fix-my-windows-headers" project which can be referenced ind the pykdtree doc for windows users hitting this problem

djhoese commented 5 years ago

Sounds good. Windows users can also use conda since conda-forge makes sure these headers are included.