search

storpipfugl / pykdtree

Fast kd-tree implementation in Python
GNU Lesser General Public License v3.0
206 stars 48 forks source link

Rerender cython module for Python 3.11 support #72

Closed djhoese closed 1 year ago

djhoese commented 1 year ago

We're seeing in the conda-forge package (https://github.com/conda-forge/pykdtree-feedstock/pull/45) that the current cython module rendered as .c is not compatible with Python 3.11. This isn't normally a problem since conda-forge regenerates the cython module every time. However, it can't do that for the emulated osx arm64 environment (still not clear to me why not). Since this issue effects all users of pykdtree on Python 3.11 I thought I'd fix it upstream too.

The long term fix is to stop pre-rendering/building the cython modules and instead have setup.py do it. This should also mean not bundling the .c cython module in the sdist and require Cython for building. I'll do this in a future PR.

djhoese commented 1 year ago

For the record, this was rerendered with cython 0.29.32 which at the time of writing is the newest version of cython.