storpipfugl / pykdtree

Fast kd-tree implementation in Python
GNU Lesser General Public License v3.0
206 stars 48 forks source link

Disable OpenMP during OSX/Windows wheel building #85

Closed djhoese closed 1 year ago

djhoese commented 1 year ago

@rayg-ssec noticed that the newest wheels have OpenMP in them and are therefore broken on most systems. Let's see how quick I can disable this.

rayg-ssec commented 1 year ago

Further details for posterity:

As a result, the binary wheel might work for intel macOS with homebrew libomp installed - though homebrew has at least one configuration where libomp is only provided as static (libomp.a).

The two main solutions as I see it are

djhoese commented 1 year ago

Thanks @rayg-ssec. It may be worth playing with https://github.com/pypa/auditwheel and see what it says. We use this in the scripts/build-manylinux-wheels.sh script in pykdtree.

djhoese commented 1 year ago

Oh nevermind, auditwheel is Linux only.

djhoese commented 1 year ago

Latest commit shows:

 OpenMP support not available.
Compiler: unix / OpenMP: None / OpenMP compile args: [] / OpenMP link args: []

For OSX and Windows so I think we're back to normal there.