issues
search
story645
/
proposal
13
stars
1
forks
source link
### Code revisions (Tom)
#11
Closed
story645
closed
3 years ago
story645
commented
3 years ago
[x] pull out args, kwargs where the possible, - can't, blows up spectacularly
[x] encoder(view[f] if f is not None else None), to be super strict on getting the key,
[x] err on the side of being super strict - will break things badly
[ ] if keys are 0,1,2,3 this model will do the right thing
[x] pull out bar to top (use scatter dataset for the bar since same topologies)
[ ] refactor multibar into seperated Q and make use of bar more
[x] rewrite Qhat paragraph, handwave to why we don't do anything w/ rho
[x] pull punchline from math into here - assemble is Q which gives X
[ ] assume reader for this section has skimmed math
[ ] how this functionality can be exploited for their purposes
[x] replace FiberBundle w/ data class?
[ ] line is assuming that we do linear interpolation on the interval - Line artist draws as linear interpolation on the segments
[x] view (takes an axes argument) is how we do sheafs or jets/restricting before we come in
[x] validation is not shown for clarity but would be implemented as part of validation
[ ] makes clear what the extension points are