search

storyblok / custom-app-examples

https://custom-app-examples.vercel.app
5 stars 1 forks source link

fix: remove `isLastAuthor` validation #22

Closed demetriusfeijoo closed 1 year ago

demetriusfeijoo commented 1 year ago

Ticket: EXT-1935 fixes #21

What

Since for every newly created space, a default story is added automatically (home) and for this story, no last_author is provided, some adjustments were required to make it optional in our starter examples and does not break the page.

Screenshot 2023-08-25 at 08 38 27

Screenshot 2023-08-25 at 08 37 51

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
app-extension-nextjs-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 2:11pm
app-extension-nuxtjs-3-starter ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2023 2:11pm
demetriusfeijoo commented 1 year ago

@eunjae-lee, the CI broking was something related to the action itself, I guess... I just rerun it and worked 😅.

eunjae-lee commented 1 year ago

I've updated the description to follow this format. Now, once this pull request gets merged, the linked issue will automatically be closed as well. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

demetriusfeijoo commented 1 year ago

Thanks for the review and also linking the issue @eunjae-lee 🙌