search

storyblok / field-plugin

Create and deploy Storyblok Field Plugin
https://www.storyblok.com/docs/plugins/field-plugins/introduction
25 stars 3 forks source link

fix(common): adding unbuild dependency to fix type problems #313

Closed BibiSebi closed 9 months ago

BibiSebi commented 9 months ago

What?

This PR evolves around adding the unbuild js dependency to field-plugin and helpers to solve type-related problems found via arethetypeswrong.github.com

In this PR the output for field-plugin seems to be passing. However as soon as I added unbuild to react helper the tests for field-plugin/react are all failing.

Screenshot 2023-11-06 at 10 50 46

UPDATE

after running yarn build:helpers from the root package and moving vite to dependencies instead of devDependencies it is possible for me to build the helpers with no problems.

Screenshot 2023-11-06 at 13 37 28

Why?

JIRA: EXT-2052

How to test? (optional)

  1. Run yarn install in the root
  2. Run yarn build:helpers inside the root package still
  3. Run attw --pack inside the field plugin package --> attw is a CLI running the same testing as the 'arethetypeswrong.github.io' website
vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 0:30am