search

storyblok / field-plugin

Create and deploy Storyblok Field Plugin
https://www.storyblok.com/docs/plugins/field-plugins/introduction
MIT License
25 stars 3 forks source link

Wrong modal iframe heigth #332

Closed geraldcloudnine closed 10 months ago

geraldcloudnine commented 10 months ago

Describe the bug The height of the iframe doesn't fill the available height of the modal.

To Reproduce Steps to reproduce the behavior:

  1. Create a new field plugin running npx @storyblok/field-plugin-cli@latest create
  2. Select React (I don't think it matters, but only tested with the React template)
  3. Run pnpm dev
  4. Open sandbox
  5. Open modal.

Expected behavior The iframe should fill the available height.

Screenshots image

Desktop (please complete the following information):

eunjae-lee commented 10 months ago

Hi @geraldcloudnine. Thanks for reaching out to us.

I just followed your instruction, and I couldn't reproduce the issue. Could you check which version of @storyblok/field-plugin you're using in your package.json?

geraldcloudnine commented 10 months ago

Hi @eunjae-lee. Thanks for looking into this.

I am using "@storyblok/field-plugin": "1.0.1".

I tested again in the sandbox and seems to work there, but not when I load it in the plugin editor (see video). The issue is also present on another plugin we currently have live at my company.

Screen Recording 2024-01-11 at 11 53 18 (1)

eunjae-lee commented 10 months ago

Hi @geraldcloudnine , we've identified the issue on our end. We're working on the fix right now, and as soon as it's released, it should be fine on your end. No action is required from you. Sorry for the inconvenience, and I will keep you updated soon.

eunjae-lee commented 10 months ago

Hi @geraldcloudnine This should be fixed now. Thanks for your patience.

geraldcloudnine commented 10 months ago

Thanks @eunjae-lee, it works great now :)