search

storyblok / field-plugin

Create and deploy Storyblok Field Plugin
https://www.storyblok.com/docs/plugins/field-plugins/introduction
25 stars 3 forks source link

feat(lib): add `interfaceLang` and `releases` to `FieldPluginData` #345

Closed eunjae-lee closed 5 months ago

eunjae-lee commented 5 months ago

What?

This PR adds interfaceLang and releases to FieldPluginData.

resolves #344

Why?

JIRA:

How to test? (optional)

storyblok.com needs to be updated first in order for us to get this data in the library.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 16, 2024 3:03pm
eunjae-lee commented 5 months ago

Hey @eunjae-lee, as per the discussion on the open ticket, I think we'll need to also accept a releaseId, right?

Or just the releases: [] would be enough? wdyt?

yeah, I tested it, and storyfront doesn't always provide releaseId (I don't understand the logic yet). It's sometimes undefined. So I thought I could expose releases only, and see if people really need releaseId :)

demetriusfeijoo commented 5 months ago

yeah, I tested it, and storyfront doesn't always provide releaseId (I don't understand the logic yet). It's sometimes undefined. So I thought I could expose releases only, and see if people really need releaseId :)

Yeah, I don't have experience on that side either, so I don't know how it behaves 😞 but we may use the open ticket to ask the user if this would be enough, wdyt?

I mean, It can happen that the user doesn't need this in the end but as it was explicitly requested, it may be better to check with him/her before.

What do you think?

eunjae-lee commented 5 months ago

If you're in a release, and click a story that belongs to the release, you'll get releaseId.

Screenshot 2024-02-16 at 12 01 15