search

storyblok / field-plugin

Create and deploy Storyblok Field Plugin
https://www.storyblok.com/docs/plugins/field-plugins/introduction
25 stars 3 forks source link

chore(deps): bump the everything group with 8 updates #359

Closed dependabot[bot] closed 4 months ago

dependabot[bot] commented 4 months ago

Bumps the everything group with 8 updates:

Package From To
@types/node 18.19.15 18.19.17
vite 5.0.11 5.1.3
vitest 1.2.2 1.3.0
react-router-dom 6.22.0 6.22.1
sass 1.70.0 1.71.0
@types/core-js 2.5.5 2.5.8
@types/react 18.2.55 18.2.56
@vitest/ui 1.2.2 1.3.0

Updates @types/node from 18.19.15 to 18.19.17

Commits


Updates vite from 5.0.11 to 5.1.3

Release notes

Sourced from vite's releases.

create-vite@5.1.0

Please refer to CHANGELOG.md for details.

Changelog

Sourced from vite's changelog.

5.1.3 (2024-02-15)

5.1.2 (2024-02-14)

5.1.1 (2024-02-09)

5.1.0 (2024-02-08)

Vite 5.1 is out! Read the announcement blog post at https://vitejs.dev/blog/announcing-vite5-1!

5.1.0-beta.7 (2024-02-07)

... (truncated)

Commits


Updates vitest from 1.2.2 to 1.3.0

Release notes

Sourced from vitest's releases.

v1.3.0

🚀 Features

🐞 Bug Fixes

... (truncated)

Commits
  • bb2af3b chore: release v1.3.0
  • bc5b2d0 fix: Prevent merging of poolOptions (#5221)
  • 1aecd65 fix(vitest): fix optimizeDeps.disabled warnings on Vite 5.1 (#5215)
  • b3182e0 chore: pass down --update flag to the project config
  • 2ee2317 ci: add publish workflow (#5168)
  • 86297d4 fix(vitest): delegate snapshot options to workspace from root config (#5199)
  • 68f5196 fix: requires fixed version across the monorepo (#5208)
  • 7d9b1fb feat(vitest): "test" accepts options object as the second parameter (#5142)
  • 656e210 fix(cli): parse --browser=\<name> correctly (#5179)
  • 828858f feat: deprecate watchExclude (#5171)
  • Additional commits viewable in compare view
Maintainer changes

This version was pushed to npm by vitestbot, a new releaser for vitest since your current version.


Updates react-router-dom from 6.22.0 to 6.22.1

Release notes

Sourced from react-router-dom's releases.

react-router-dom-v5-compat@6.4.0-pre.15

Patch Changes

  • Updated dependencies
    • react-router@6.4.0-pre.15
    • react-router-dom@6.4.0-pre.15

react-router-dom-v5-compat@6.4.0-pre.11

Patch Changes

  • Updated dependencies
    • react-router@6.4.0-pre.11
    • react-router-dom@6.4.0-pre.11

react-router-dom-v5-compat@6.4.0-pre.10

Patch Changes

  • Updated dependencies
    • react-router@6.4.0-pre.10
    • react-router-dom@6.4.0-pre.10

react-router-dom-v5-compat@6.4.0-pre.9

Patch Changes

  • Updated dependencies
    • react-router@6.4.0-pre.9
    • react-router-dom@6.4.0-pre.9

react-router-dom-v5-compat@6.4.0-pre.8

Patch Changes

  • Updated dependencies
    • react-router@6.4.0-pre.8
    • react-router-dom@6.4.0-pre.8

react-router-dom-v5-compat@6.4.0-pre.7

Patch Changes

  • Updated dependencies
    • react-router@6.4.0-pre.7
    • react-router-dom@6.4.0-pre.7

react-router-dom-v5-compat@6.4.0-pre.6

Patch Changes

  • 44bce3c6: Fix react-router-dom peer dependency version
    • react-router@6.4.0-pre.6
    • react-router-dom@6.4.0-pre.6

react-router-dom-v5-compat@6.4.0-pre.5

... (truncated)

Changelog

Sourced from react-router-dom's changelog.

6.22.1

Patch Changes

  • Updated dependencies:
    • react-router@6.22.1
    • @remix-run/router@1.15.1
Commits


Updates sass from 1.70.0 to 1.71.0

Release notes

Sourced from sass's releases.

Dart Sass 1.71.0

To install Sass 1.71.0, download one of the packages below and add it to your PATH, or see the Sass website for full installation instructions.

Changes

For more information about pkg: importers, see the announcement on the Sass blog.

Command-Line Interface

  • Add a --pkg-importer flag to enable built-in pkg: importers. Currently this only supports the Node.js package resolution algorithm, via --pkg-importer=node. For example, @use "pkg:bootstrap" will load node_modules/bootstrap/scss/bootstrap.scss.

JavaScript API

  • Add a NodePackageImporter importer that can be passed to the importers option. This loads files using the pkg: URL scheme according to the Node.js package resolution algorithm. For example, @use "pkg:bootstrap" will load node_modules/bootstrap/scss/bootstrap.scss. The constructor takes a single optional argument, which indicates the base directory to use when locating node_modules directories. It defaults to path.dirname(require.main.filename).

Dart API

  • Add a NodePackageImporter importer that can be passed to the importers option. This loads files using the pkg: URL scheme according to the Node.js package resolution algorithm. For example, @use "pkg:bootstrap" will load node_modules/bootstrap/scss/bootstrap.scss. The constructor takes a single argument, which indicates the base directory to use when locating node_modules directories.

See the full changelog for changes in earlier releases.

Changelog

Sourced from sass's changelog.

1.71.0

For more information about pkg: importers, see the announcement on the Sass blog.

Command-Line Interface

  • Add a --pkg-importer flag to enable built-in pkg: importers. Currently this only supports the Node.js package resolution algorithm, via --pkg-importer=node. For example, @use "pkg:bootstrap" will load node_modules/bootstrap/scss/bootstrap.scss.

JavaScript API

  • Add a NodePackageImporter importer that can be passed to the importers option. This loads files using the pkg: URL scheme according to the Node.js package resolution algorithm. For example, @use "pkg:bootstrap" will load node_modules/bootstrap/scss/bootstrap.scss. The constructor takes a single optional argument, which indicates the base directory to use when locating node_modules directories. It defaults to path.dirname(require.main.filename).

Dart API

  • Add a NodePackageImporter importer that can be passed to the importers option. This loads files using the pkg: URL scheme according to the Node.js package resolution algorithm. For example, @use "pkg:bootstrap" will load node_modules/bootstrap/scss/bootstrap.scss. The constructor takes a single argument, which indicates the base directory to use when locating node_modules directories.
Commits


Updates @types/core-js from 2.5.5 to 2.5.8

Commits


Updates @types/react from 18.2.55 to 18.2.56

Commits


Updates @vitest/ui from 1.2.2 to 1.3.0

Release notes

Sourced from @​vitest/ui's releases.

v1.3.0

🚀 Features

🐞 Bug Fixes

... (truncated)

Commits
Maintainer changes

This version was pushed to npm by vitestbot, a new releaser for @​vitest/ui since your current version.


Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore major version` will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself) - `@dependabot ignore minor version` will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself) - `@dependabot ignore ` will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself) - `@dependabot unignore ` will remove all of the ignore conditions of the specified dependency - `@dependabot unignore ` will remove the ignore condition of the specified dependency and ignore conditions
vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plugin-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 23, 2024 2:13pm
eunjae-lee commented 4 months ago

yarn tries to keep as many dependencies as possible at the root node_modules folder. but sometimes some packages (within the monorepo) have to have their own node_modules folder when the package uses a different version of a certain package that is already in the root node_modules.

As we use dependabot and manage all the versions centrally, we've found a case that templates/js package no longer need its own node_modules folder. And we have a script to copy a temp version of vite config into node_modules. And it failed because the folder didn't exist! (what a rare case)

Anyway, I've updated the script to create the folder if it's missing.

eunjae-lee commented 4 months ago

still getting type error. I ran into this in the previous PR, but don't remember how I fixed it 🥲 i'll get back to this tomorrow.

dependabot[bot] commented 4 months ago

Looks like these dependencies are updatable in another way, so this is no longer needed.

eunjae-lee commented 4 months ago

Looks like these dependencies are updatable in another way, so this is no longer needed.

Why didn't you close this PR? I was working on it 😭

eunjae-lee commented 4 months ago

I've added skipLibCheck to the root tsconfig.base.json as it was failing with this error:

➜ yarn workspace @storyblok/field-plugin check:types
../../node_modules/@types/react-dom/node_modules/@types/react/index.d.ts:4127:14 - error TS2300: Duplicate identifier 'ElementType'.

4127         type ElementType = string | React.JSXElementConstructor<any>;
                  ~~~~~~~~~~~

  ../../node_modules/@types/react/index.d.ts:4127:14
    4127         type ElementType = string | React.JSXElementConstructor<any>;
                      ~~~~~~~~~~~
    'ElementType' was also declared here.

../../node_modules/@types/react-dom/node_modules/@types/react/index.d.ts:4141:14 - error TS2300: Duplicate identifier 'LibraryManagedAttributes'.

4141         type LibraryManagedAttributes<C, P> = C extends
                  ~~~~~~~~~~~~~~~~~~~~~~~~

  ../../node_modules/@types/react/index.d.ts:4141:14
    4141         type LibraryManagedAttributes<C, P> = C extends
                      ~~~~~~~~~~~~~~~~~~~~~~~~
    'LibraryManagedAttributes' was also declared here.

../../node_modules/@types/react/index.d.ts:4127:14 - error TS2300: Duplicate identifier 'ElementType'.

4127         type ElementType = string | React.JSXElementConstructor<any>;
                  ~~~~~~~~~~~

  ../../node_modules/@types/react-dom/node_modules/@types/react/index.d.ts:4127:14
    4127         type ElementType = string | React.JSXElementConstructor<any>;
                      ~~~~~~~~~~~
    'ElementType' was also declared here.

../../node_modules/@types/react/index.d.ts:4141:14 - error TS2300: Duplicate identifier 'LibraryManagedAttributes'.

4141         type LibraryManagedAttributes<C, P> = C extends
                  ~~~~~~~~~~~~~~~~~~~~~~~~

  ../../node_modules/@types/react-dom/node_modules/@types/react/index.d.ts:4141:14
    4141         type LibraryManagedAttributes<C, P> = C extends
                      ~~~~~~~~~~~~~~~~~~~~~~~~
    'LibraryManagedAttributes' was also declared here.

Found 4 errors in 2 files.

Errors  Files
     2  ../../node_modules/@types/react-dom/node_modules/@types/react/index.d.ts:4127
     2  ../../node_modules/@types/react/index.d.ts:4127

node_modules is obviously excluded from the config, but it seems there are some situations when this exclude of tsconfig is not respected. So far, skipLibCheck has been the only solution to this issue.

https://www.typescriptlang.org/tsconfig/#skipLibCheck

BibiSebi commented 4 months ago

I've added skipLibCheck to the root tsconfig.base.json as it was failing with this error:

➜ yarn workspace @storyblok/field-plugin check:types
../../node_modules/@types/react-dom/node_modules/@types/react/index.d.ts:4127:14 - error TS2300: Duplicate identifier 'ElementType'.

4127         type ElementType = string | React.JSXElementConstructor<any>;
                  ~~~~~~~~~~~

  ../../node_modules/@types/react/index.d.ts:4127:14
    4127         type ElementType = string | React.JSXElementConstructor<any>;
                      ~~~~~~~~~~~
    'ElementType' was also declared here.

../../node_modules/@types/react-dom/node_modules/@types/react/index.d.ts:4141:14 - error TS2300: Duplicate identifier 'LibraryManagedAttributes'.

4141         type LibraryManagedAttributes<C, P> = C extends
                  ~~~~~~~~~~~~~~~~~~~~~~~~

  ../../node_modules/@types/react/index.d.ts:4141:14
    4141         type LibraryManagedAttributes<C, P> = C extends
                      ~~~~~~~~~~~~~~~~~~~~~~~~
    'LibraryManagedAttributes' was also declared here.

../../node_modules/@types/react/index.d.ts:4127:14 - error TS2300: Duplicate identifier 'ElementType'.

4127         type ElementType = string | React.JSXElementConstructor<any>;
                  ~~~~~~~~~~~

  ../../node_modules/@types/react-dom/node_modules/@types/react/index.d.ts:4127:14
    4127         type ElementType = string | React.JSXElementConstructor<any>;
                      ~~~~~~~~~~~
    'ElementType' was also declared here.

../../node_modules/@types/react/index.d.ts:4141:14 - error TS2300: Duplicate identifier 'LibraryManagedAttributes'.

4141         type LibraryManagedAttributes<C, P> = C extends
                  ~~~~~~~~~~~~~~~~~~~~~~~~

  ../../node_modules/@types/react-dom/node_modules/@types/react/index.d.ts:4141:14
    4141         type LibraryManagedAttributes<C, P> = C extends
                      ~~~~~~~~~~~~~~~~~~~~~~~~
    'LibraryManagedAttributes' was also declared here.

Found 4 errors in 2 files.

Errors  Files
     2  ../../node_modules/@types/react-dom/node_modules/@types/react/index.d.ts:4127
     2  ../../node_modules/@types/react/index.d.ts:4127

node_modules is obviously excluded from the config, but it seems there are some situations when this exclude of tsconfig is not respected. So far, skipLibCheck has been the only solution to this issue.

https://www.typescriptlang.org/tsconfig/#skipLibCheck

This is interesting, i will try this locally tomorrow aswell if it's ok with you :)

eunjae-lee commented 4 months ago

LGTM @eunjae-lee.

I've tested it locally and it seems to be working nicely 💯

In the end, how the issue with checking the node_modules folder was solved? I ask because I saw the skipLibCheck config was added but then removed and the error is not happening anymore 🤣 .

I'm not too sure exactly, but I assume there were duplicated libraries (probably different versions), and tsc failed with it. However, after removing yarn.lock and reinstalling dependencies, they lined up and now we use the same version, and the error no longer happens.