Closed demetriusfeijoo closed 7 months ago
vercel[bot]
commented
7 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| plugin-sandbox | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 7, 2024 0:34am |
demetriusfeijoo
commented
7 months ago Thanks for your reviews 💯 and I agree with the definition you brought, @eunjae-lee. 🙌
We could have a container connector that would be used for all the cases? 🤔 I mean, one library that should be able to be added to any project that wants to become a plugin container or to have its capacity.
It could be used for the Visual Editor, Plugin Editor, Sandbox, @storyblok/field-plugin/test, or any other.
eunjae-lee
commented
7 months ago Thanks for your reviews 💯 and I agree with the definition you brought, @eunjae-lee. 🙌
We could have a
container connectorthat would be used for all the cases? 🤔 I mean, one library that should be able to be added to any project that wants to become a plugin container or to have its capacity.It could be used for the Visual Editor, Plugin Editor, Sandbox,
@storyblok/field-plugin/test, or any other.
yeah I guess it would look something like createContainer(params) and can be used both in @storyblok/field-plugin/test and this Sandbox project.
What?
packages/containertopackages/sandboxcontainertosandboxpackage.jsonto consider the new project's namecontainerwithsandboxin theCONTRIBUTING.mdfileWhy?
JIRA: EXT-1470
The term
containeris too open, and not widely adopted by us when referring to the Sandbox. Replacing it will drive us to have a "ubiquitous language" which will also lead to a better DX.PS: The Vercel action is not running yet since it wasn't modified to consider the new path (
packages/sandbox) and also the new project name in its settings.PS2: The Sandbox can run locally, but it isn't loading any plugin due to this issue. So, I advise you to check into this branch and perform the tests there since this one is on top of this.