search

storyblok / storyblok-js

JavaScript SDK to connect Storyblok with your favourite framework that we don't have an official SDK for.
http://storyblok.com/
MIT License
39 stars 20 forks source link

Project is forcing eslint, but is not properly set up for typescript #237

Closed SebbeJohansson closed 1 year ago

SebbeJohansson commented 1 year ago

During commit, an error from eslint is thrown. Causing any commits using a proper git client to be impossible. image

Expected Behavior

I expect to be able to do proper commits using a git client.

Current Behavior

It errors because of typescript: image

Steps to Reproduce

  1. Make a commit.
  2. Try to push it via git.
  3. It errors.

Resources: https://www.reddit.com/r/typescript/comments/q378h9/component_props_error_parsing_error_unexpected/ https://www.appsloveworld.com/reactjs/100/5/eslint-parsing-error-unexpected-token-on-typescript-cast-operator-as https://frontendfolks.com/posts/parsing-error-unexpected-token-eslint-typescript/53 https://stackoverflow.com/questions/60547153/eslint-parsing-error-unexpected-token-on-typescript-cast-operator-as

SebbeJohansson commented 1 year ago

I had to do my changes using edit in github since it was blocking me from using git properly.

fgiuliani commented 1 year ago

Hi @SebbeJohansson is this still happening to you? What project are you trying to edit?

SebbeJohansson commented 1 year ago

@fgiuliani hi, any part of this repo produces this error after doing a fork and then trying to commit to it.

alexjoverm commented 1 year ago

Hi @SebbeJohansson I'm not able to reproduce it myself. I see you're working on Windows, not sure if related by maybe some specific Windows config for TypeScript are needed?

SebbeJohansson commented 1 year ago

@alexjoverm Didnt know that it could differ with that, but maybe. Not sure which thing helped, but i updated my fork to the latest main branch and switched computer and that worked. So seems like the issue is gone. Ill close.