Fix the resolveRelations() method for the case with relations with n…

[roberto-butti]

…ame conflict

Pull request type

Jira Link: [INT-766(url)

• [x] Bugfix
• [ ] Feature
• [ ] Code style update (formatting, renaming)
• [ ] Refactoring (no functional changes, no api changes)
• [ ] Other (please describe):

How to test this PR

This issue is in the resolveRelations() method in the Client class.

The test case is this one:

$resolveRelations = "Menus.item,item.singleMenuEntry,singleMenuEntry.ctaLink,singleMenuEntry.mainSection,singleMenuEntry.secondarySection";
$result = $client
    ->editMode()
    ->language('it')
    ->resolveRelations($resolveRelations)
    ->getStoryBySlug('header-and-footer/headercareers')->getBody();

The current implementation of resolve relations create an array using as key the first part of the relations. In the test case are:

• Menus.item
• item.singleMenuEntry
• singleMenuEntry.ctaLink
• singleMenuEntry.mainSection
• singleMenuEntry.secondarySection

If you are using as key the first part (before the dot), you have “conflict for:

• singleMenuEntry.ctaLink
• singleMenuEntry.mainSection
• singleMenuEntry.secondarySection

Now for preserving all the relations, the resolveRelations method now creates an array of array like this one:

Array
(
    [Menus] => Array
        (
            [0] => item
        )

    [item] => Array
        (
            [0] => singleMenuEntry
        )

    [singleMenuEntry] => Array
        (
            [0] => ctaLink
            [1] => mainSection
            [2] => secondarySection
        )

)

Now in the insertRelations() method, instead of checking if the field is equal to the element of the array, I modified the "if condition" to check if the field is in the array.

[roberto-butti]

@joaokamun and @ademarCardoso I also added 3 test cases for testing nested relations and more than 50 relations that allow the APIs to reply with rel_uuids. If you agree, we can merge this PR.

You can see the tests:

vendor/bin/pest --filter "Integration: get one story with Resolved relations"

[joaokamun]

Looks great!

[roberto-butti]

Ehi @ademarCardoso , removed comments : https://github.com/storyblok/php-client/pull/83/commits/f7b60fc0c33f081694c309ea09553b1958bb790d