INT-979 Added SDK version and send as headers on each call

storyblok / storyblok-php-client

Storyblok - PHP Client

https://www.storyblok.com

MIT License

33 stars 37 forks source link

INT-979 Added SDK version and send as headers on each call #90

Closed joaokamun closed 1 year ago

joaokamun commented 1 year ago

Pull request type

Jira Link: INT-979

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Other (please describe):

How to test this PR

Send a request and check the headers, must be present either the SB-AGENT and SB-AGENT-VERSION.

What is the new behavior?

It has a constant with the current SDK version and it send through headers on each call.

Other information

All new releases should update the new const on Client class.

roberto-butti commented 1 year ago

I was thinking to use this:

\Composer\InstalledVersions::getPrettyVersion('storyblok/storyblok-php-client');

I need to think about side effects, but let me know what do you think

joaokamun commented 1 year ago

I was thinking to use this:
\Composer\InstalledVersions::getPrettyVersion('storyblok/storyblok-php-client');
I need to think about side effects, but let me know what do you think

The tests will broken because the package itself don't have his own installed via composer. Package "storyblok/storyblok-php-client" is not installed