Increase phpstan level to 9 and put everything into the baseline - Githubissues

storyblok / storyblok-php-client

Storyblok - PHP Client

https://www.storyblok.com

MIT License

33 stars 37 forks source link

Increase phpstan level to 9 and put everything into the baseline #94

Closed pscheit closed 2 months ago

pscheit commented 1 year ago

You started at level 1 and you are constantly moving up levels. But imho its better to baseline everything. Here is reasoning from the author of phpstan: https://phpstan.org/blog/phpstans-baseline-feature-lets-you-hold-new-code-to-a-higher-standard

in a nutshell: chew on the baseline, let new code only pass level 9, so that you dont create static bugs.

Pull request type

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[x] Other (please describe): improves handling of phpstan analysis

How to test this PR

run phpstan, should be green

What is the new behavior?

phpstan runs on level 9, but still passes
the workflow is now: fix a bug, remove it from the baseline.

pscheit commented 1 year ago

needs https://github.com/storyblok/storyblok-php-client/pull/96 to be merged and a rebase