fix: no knobs after select

nekitk commented 5 years ago

Fixes https://github.com/storybookjs/addon-smart-knobs/issues/59 Fixes https://github.com/storybookjs/addon-smart-knobs/issues/30

Storybook fails to render next knobs when you pass to select options object with an empty key. Replaced empty key with --
Choosing empty option was setting prop value to -- which is undesired (because it is truthy). We can't set it to undefined for now (https://github.com/storybookjs/storybook/issues/4487), so I replaced it with null
Empty option in select was available even for required props. Changed it so it is added only for props that are not required.

sami616 commented 5 years ago

This would be a great addition. As a work around I am passing an empty string as the default value.

RoyalHunt commented 5 years ago

Waiting this pr for a while. Any progress?

vercel[bot] commented 4 years ago

This pull request is being automatically deployed with ZEIT Now (learn more). To see the status of your deployment, click below or on the icon next to each commit.

vercel[bot] commented 4 years ago

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

vercel[bot] commented 4 years ago

Deployment failed with the following error:

Your `package.json` file is missing a `build` property inside the `script` property.

storybook-eol / addon-smart-knobs

fix: no knobs after select #60