search

storybook-eol / storybook-addon-options

REPO/PACKAGE MOVED - Storybook UI Options Addon
https://github.com/storybooks/storybook/tree/master/addons/options
30 stars 7 forks source link

Remove storybook-addons from peerDependencies #11

Closed thebuilder closed 7 years ago

thebuilder commented 7 years ago

@kadira/storybook-addons is already a dependency of "@kadira/storybook". You shouldn't need to install in manually.

ndelangen commented 7 years ago

Thank you for contributing! storybook-addons is required in this code path: https://github.com/storybooks/storybook-addon-options/blob/f12e5541e8bca798beb7d4189975f70cfce381d8/src/manager/index.js#L2

So not declaring this dependency would be incorrect?

peerDependencies should not have to be installed manually, where did you find this information? Did you run into an error when not installing manually? If so, that sounds like a bug to me.

thebuilder commented 7 years ago

The reason for this was to get rid of the package installation warning you get:

warning "@kadira/storybook-addon-options@1.0.2" has unmet peer dependency "@kadira/storybook-addons@^1.5.0".

I realise storybook-addons-options requires storybook-addons, but since you will always use options with Storybook itself, and Storybook has added the dependency for storybook-addons to its ´package.json`.

ndelangen commented 7 years ago

If you could provide a simple reproduction path to how to get this warning, I can try that locally.

Sounds like the installation happens in the wrong order.

ndelangen commented 7 years ago

Hey @thebuilder

Thank you so much for this PR! We're moving over to a mono-repo, since that makes a lot of sense for a project like this. We would ❤️ it if you could create a PR here: https://github.com/storybooks/storybook

That'd be awesome, thanks!