search

storybook-eol / storybook-addon-options

REPO/PACKAGE MOVED - Storybook UI Options Addon
https://github.com/storybooks/storybook/tree/master/addons/options
30 stars 7 forks source link

Need to press keyboard shortcuts twice with empty query string #9

Closed usulpro closed 7 years ago

usulpro commented 7 years ago

steps to reproduce:

1 set any option e.g. goFullScreen: true, 2 open storybook by url like http://localhost:9001/ 3 press Ctrl-Shift-F 4 press Ctrl-Shift-F again

expected behavior:

after [3] storybook should exit from fullscreen mode

real behavior:

after [3] it flashes 'non fullscreen mode' and then it goes back to fullscreen next pressing Ctrl-Shift-F works properly

example:

https://sm-react.github.io/react-theming/

(it starts in fullscreen mode)

usulpro commented 7 years ago

Now it works properly, thank you!

arunoda commented 7 years ago

BTW: How does it suppose get fixed? Did I miss some discussion related to this?

usulpro commented 7 years ago

@arunoda after the last release it starts to work properly I just noticed it and wrote :)

arunoda commented 7 years ago

Awesome. I think we can close this now.