search

storybook-eol / storybook-deployer

Deploy your storybook as a static site
MIT License
894 stars 71 forks source link

fix issue where new repo didn't set matching source branch #87

Closed stephenhmarsh closed 3 years ago

stephenhmarsh commented 4 years ago

this fixes https://github.com/storybookjs/storybook-deployer/issues/86 for me

stephenhmarsh commented 4 years ago

It seems strange that the "source branch" flag doesn't (currently) mean something like "a different branch of your project to build the storybook from, rather than the current branch." This is what I would assume from the name and the docs.

Instead, the command on line 76 (git push --force --quiet ${GIT_URL} ${SOURCE_BRANCH}:${TARGET_BRANCH}) uses "source branch" in the context of the new, temporary repo in OUTPUT_DIR.

I'm wondering if there shouldn't also be a much earlier step to git checkout <source-branch> before anything is built?

hipstersmoothie commented 3 years ago

:rocket: PR was released in v2.8.10 :rocket: