storybookjs / addon-cssresources

A storybook addon to switch between css resources at runtime for your story
MIT License
7 stars 3 forks source link

Use the new Framework API #7

Open jonniebigodes opened 1 year ago

jonniebigodes commented 1 year ago

Opening this issue so we can address the upcoming changes on how addons are built/updated for the upcoming 7.0 release. If anyone is interested in making the changes required and continuing to support and maintain the addon, let us know so that we're aware and help/guide the community moving forward. To help with this process, we've built an abridged guide here, and should any questions or issues, please reach out to us in the prerelease channel in our Discord Server.

senicar commented 1 year ago

@jonniebigodes hi, since we are using this addon in our project I tried to update it so it would work on Storybook 7.0

I created a fork at https://github.com/senicar/addon-cssresources/commit/3ee284e0069ecb4a4a29ceb54bda5b5934c807a1, if you would be kind enough to take a look and propose any improvements, since this is my first time working on a Storybook addon. Once it is ready, I'll gladly create a pull request :) thnx

JReinhold commented 1 year ago

Hi @senicar Storybook v7.0.0 is out. It's only on the next tag for now, but it's still targetable with the ^7.0.0 semver range, so you should be able to develop against it with no dependency issues.

Your changes looks good, and if they work for you in v7 then please do open a PR and we'll gladly release it! I'd suggest you check the console and the terminal for any deprecation warnings, and see if you need to change anything based on that.

If you hit any issues with v7, we've written a migration guide for addon authors here and here.

You're also free to reach out to us in the #prerelease channel on our Discord Server and we'll happily help you out!

cc @ndelangen

EliezerB123 commented 1 year ago

Is there any update on this?

gitawego commented 6 months ago

same question, any update ?

EliezerB123 commented 1 month ago

@JReinhold @jonniebigodes There's a pull request here... Pull Request

Does it need a separate migration to update it to Storybook 8?