search

storybookjs / addon-designs

A Storybook addon that embeds Figma, websites, or images in the addon panel.
https://storybookjs.github.io/addon-designs
MIT License
876 stars 71 forks source link

renderTarget: tab no longer works #134

Closed sysofwan closed 2 years ago

sysofwan commented 2 years ago

Describe the bug

Usage with tab rendering no longer works in the demo here.

I suspect this is caused by this PR. I think the tab addons does not support function titles.

How to reproduce the bug?

  1. Navigate to tab demo here.
  2. Observe that design tab does not render.

Expected behaviour

Design tab should render

Affected versions

6.1.0

Storybook versions

6.4.9

pocka commented 2 years ago

Thank you for reporting. I released storybook-addon-designs@v6.2.1, which includes a patch for the bug.

sysofwan commented 2 years ago

Thank you!

ThomasCarca commented 1 year ago

Hello this seems broken again in the latest version. We had to revert to v6.2.1 where it seems to work just fine.

pocka commented 1 year ago

Would you mind opening a new issue?