storybookjs / addon-designs

A Storybook addon that embeds Figma, websites, or images in the addon panel.
https://storybookjs.github.io/addon-designs
MIT License
876 stars 71 forks source link

Docs and demo page is 404 #187

Closed jeanbaptistesouvestre closed 1 year ago

jeanbaptistesouvestre commented 1 year ago

Affected design types

Describe the bug

The link displayed in the readme, and the sidebar https://pocka.github.io/storybook-addon-designs is 404

How to reproduce the bug?

Go to https://pocka.github.io/storybook-addon-designs

Expected behaviour

https://pocka.github.io/storybook-addon-designs correctly displays doc and demo,

or links are updated to the correct url

Environment

Affected versions

N/A

Storybook versions

N/A

ryarturogi commented 1 year ago

Yep, 404 down

yannbf commented 1 year ago

Hey peeps! The project has recently been moved between repos, which is why the website is down. @pocka what do you think is the best way forward? should we host this on netlify or something?

pocka commented 1 year ago

@yannbf I disabled the GitHub Pages as I thought it affects billing (traffic and/or file size, turns out wrong)... I have no strong opinion about where to host. Hosting on Storybook org maintainers' preferable service would be the best for maintainability. If code tweaks or something is needed, please let me know. (Re-enabling GitHub Pages would be easy: just restore deploy-ghpages.yml)

valioDOTch commented 1 year ago

It seems that this project is now linking to https://storybookjs.github.io/addon-designs for "Docs & Demos"

However that's also a dead-end.

pocka commented 1 year ago

@yannbf Let me know if you are okay with hosting "Docs & Demos" under https://storybookjs.github.io/addon-designs, I'll re-enable GH Pages hosting workflow and make sure everything works then.

yannbf commented 1 year ago

Thanks pocka! This issue has been solved, the demo pages are available now, though they should be updated as they are still showing Storybook 6.5

cc @thafryer

thafryer commented 1 year ago

@pocka Can you go ahead and re-enable the GH pages hosting workflow?

pocka commented 1 year ago

@pocka Can you go ahead and re-enable the GH pages hosting workflow?

Yes, sure.