storybookjs / addon-designs

A Storybook addon that embeds Figma, websites, or images in the addon panel.
https://storybookjs.github.io/addon-designs
MIT License
870 stars 73 forks source link

Support SB7 #191

Closed yarinsa closed 1 year ago

yarinsa commented 1 year ago

Is your feature request related to a problem? Please describe. Yes. We are starting a new design system based on SB7, which will be stable in the next few weeks. When can we expect support?

Describe the solution you'd like Upgrade to the new adding api

Describe alternatives you've considered None.

byjokese commented 1 year ago

Same Here, testing the pre-release version of the final v7.0.0, and many add-ons broke as the plugin API changed.

Interested in the new update for addon-designs.

Codex- commented 1 year ago

We've been using https://github.com/storybookjs/addon-designs/releases/tag/v7.0.0-beta.2 successfully, would be great to see a stable release though :)

Worth reading this comment: https://github.com/storybookjs/addon-designs/issues/178#issuecomment-1379784068 As referenced here: https://github.com/storybookjs/storybook/issues/20529

byjokese commented 1 year ago

Yep, did not see the beta, with the beta.2 works perfectly.

Codex- commented 1 year ago

If you encounter this:

▲ [WARNING] Calling "copy" will crash at run-time because it's an import namespace object, not a function [call-import-namespace]

    node_modules/@figspec/components/esm/es2015/FigspecViewer/InspectorView/InspectorView.js:62:42:
      62 │               ${CopyIcon({ onClick: () => copy(node.characters) })}
         ╵                                           ~~~~

  Consider changing "copy" to a default import instead:

    node_modules/@figspec/components/esm/es2015/FigspecViewer/InspectorView/InspectorView.js:2:7:
      2 │ import * as copy from "copy-to-clipboard";
        │        ~~~~~~~~~
        ╵        copy

Then remove storybook-addon-designs (and anything else showing as an importer via npm ls @figspec/components), perform an npm i, then add it back, and npm i again. This should bump the lock version, which resolves the error upstream. Or add @figspec/components as a dep@latest then remove it again :)

mayerraphael commented 1 year ago

Does not work with 7.0.7. getChannel() is not defined error.

immanual-tsw commented 1 year ago

Hi, I am getting this warning while installing storybook-addon-designs.

"Attention: We've detected that you're using the following addons in versions which are known to be incompatible with Storybook 7:

pocka commented 1 year ago

WIP #192

thafryer commented 1 year ago

Hi Everyone! We have released a new version of the addon. We also changed the package name for the addon, @storybook/addon-designs. Please follow instructions from the readme to get going with the latest version.

https://github.com/storybookjs/addon-designs/blob/master/README.md