search

storybookjs / addon-designs

A Storybook addon that embeds Figma, websites, or images in the addon panel.
https://storybookjs.github.io/addon-designs
MIT License
869 stars 73 forks source link

Upgrade to Storybook 8 #232

Closed JReinhold closed 6 months ago

JReinhold commented 6 months ago

Closes #231, #229

This PR does a lot of things:

  1. Upgrade bundling strategy to use tsup similar to how it's done in addon-kit
  2. Upgrade all internal Storybooks to SB 8
  3. Combine examples and examples-tab Storybooks into a single Storybook, while still maintaining their separation of / for examples and /tab/ for tab examples
  4. Upgrade almost all dependencies throughout the repository
  5. Formatted the project according to the existing configuration

Todo

📦 Published PR as canary version: 8.0.0--canary.232.a463deb.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/addon-designs@8.0.0--canary.232.a463deb.0 # or yarn add @storybook/addon-designs@8.0.0--canary.232.a463deb.0 ```
valentinpalkovic commented 6 months ago

@JReinhold: Out of the 13 reported issues, how many would you consider helpful and valuable? And a second question: I think, most errors might not have been reported if TypeScript had been set up stricter (strict mode, for example). Is that the case?

JReinhold commented 6 months ago

@valentinpalkovic quickly looking through them, they would all have been caught by a stricter TypeScript mode, so I don't find this specific scenario useful, except for anything else than "you should make your TS config more strict".

bodograumann commented 6 months ago

I have tried 8.0.0--canary.232.785af00.0 and it works fine afaics. :heart: