storybookjs / addon-designs

A Storybook addon that embeds Figma, websites, or images in the addon panel.
https://storybookjs.github.io/addon-designs
MIT License
869 stars 73 forks source link

Figma new link is not working anymore #244

Closed MChrys closed 2 months ago

MChrys commented 2 months ago

Affected design types

Describe the bug

my old component link from figma is still working but now, I tried to update link (add new also in new stoy) now this is what I get in my story book

image

I'm still using the same browser (chrome) what is weird is my old link still loading properly but is I'm copy paste the updated link of the same component it is not working .

How to reproduce the bug?

go in figma and get a new link with cmd + L or right click copy and copy link to selection

add it in your story like that :

export const Default: Story = {
  parameters: {
    design: {
      type: 'figma',
      url: 'https://www.figma.com/design/t8x8Z4dRrFG5WjZ2WWVisd/space?node-id=687-19311&t=p3wjagyQydsnxEu0-4',
    },
  },
  args: {},
};

and save and check in your storybook the figma tab in the related story

Expected behaviour

I expected the figma view load properly like before

Environment

Affected versions

lastest

Storybook versions

lastest

CollinHerber commented 2 months ago

Getting this as well with

Refused to frame 'https://www.figma.com/' because an ancestor violates the following Content Security Policy directive: "frame-ancestors 'self' vscode-webview: vscode-file:".

Logged in the console

CollinHerber commented 2 months ago

Looks like it may be related to https://github.com/storybookjs/addon-designs/pull/240/files

MChrys commented 2 months ago

how would you explain that the old link of the same component is still working ?

pocka commented 2 months ago

Duplicate of #239