search

storybookjs / addon-styling

A base addon for configuring popular styling tools
MIT License
44 stars 10 forks source link

Move to yarn 3 #69

Closed ShaunEvening closed 1 year ago

ShaunEvening commented 1 year ago
📦 Published PR as canary version: 1.3.3--canary.69.6753c6f.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/addon-styling@1.3.3--canary.69.6753c6f.0 # or yarn add @storybook/addon-styling@1.3.3--canary.69.6753c6f.0 ```
socket-security[bot] commented 1 year ago

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@types/node 20.4.1 None +0 3.81 MB types
less 4.1.3 eval, network, filesystem, environment +10 3.63 MB matthew-dean
less-loader 11.1.2 network +12 3.68 MB evilebottnawi
@storybook/react-vite 7.0.24...7.0.27 None +5/-70 4.19 MB shilman
recast 0.23.2...0.23.3 None +0/-1 244 kB eventualbuddha

🚮 Removed packages: @babel/cli@7.22.5, @babel/core@7.22.5, @babel/preset-env@7.22.5, @babel/preset-react@7.22.5, @storybook/addon-essentials@7.0.24, @storybook/builder-webpack5@7.0.24, @storybook/core-common@7.0.24, @storybook/csf-tools@7.0.24, @storybook/react@7.0.24, storybook@7.0.24, vite@4.3.9

socket-security[bot] commented 1 year ago

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Bin script confusion @nicolo-ribaudo/semver-v6 6.3.3
Bin script confusion semver 5.7.2
Bin script confusion semver 6.3.1
Bin script confusion semver 7.0.0
Bin script confusion semver 7.5.4
New author nopt 6.0.0
Shell access node-gyp 9.4.0
Uses eval less 4.1.3

Next steps

What is bin script confusion?

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore less@4.1.3
  • @SocketSecurity ignore nopt@6.0.0
  • @SocketSecurity ignore node-gyp@9.4.0
  • @SocketSecurity ignore @nicolo-ribaudo/semver-v6@6.3.3
  • @SocketSecurity ignore semver@5.7.2
  • @SocketSecurity ignore semver@6.3.1
  • @SocketSecurity ignore semver@7.0.0
  • @SocketSecurity ignore semver@7.5.4
TyIsI commented 1 year ago

Sorry, to comment here, but I figured I would ask this before opening an issue.

Was prettier intended to be a production dependency?

ShaunEvening commented 1 year ago

Hey @TyIsI

Yes it was. For the auto-configuration code mods it runs prettier afterward to protect a users formatting