storybookjs / addon-svelte-csf

[Incubation] CSF using Svelte components.
MIT License
103 stars 32 forks source link

Fix missing types by adding back `main` and `types` fields #118

Closed hobbes7878 closed 1 year ago

hobbes7878 commented 1 year ago

… so TS node10 moduleResolution still works per #116.

JReinhold commented 1 year ago

I'm just testing the canary 3.0.7--canary.d7ef15d.0 against https://github.com/olafurw/addon-svelte-csf-import-bug to make sure it works.

EDIT: Works, in the repro at least

olafurw commented 1 year ago

Tested locally with canary version, works great.

https://github.com/olafurw/addon-svelte-csf-import-bug/actions/runs/5726789194/job/15517919448

Thank you @hobbes7878 and @JReinhold

shilman commented 1 year ago

:rocket: PR was released in v3.0.7 :rocket:

paoloricciuti commented 1 year ago

Uh that's strange...my fix was working locally...than all of a sudden it stopped working. This seems to have fixed it once and for all.