search

storybookjs / addon-svelte-csf

[Incubation] CSF using Svelte components.
MIT License
103 stars 32 forks source link

Fix: `typeof Meta` in Svelte v3 (Pin Svelte peer dependency to v3) #127

Closed JReinhold closed 1 year ago

JReinhold commented 1 year ago

Works on https://github.com/storybookjs/addon-svelte-csf/issues/121#issuecomment-1686214199

cc @RSWilli

This PR pins the allowed Svelte version to v3, because it's not possible to provide correct typings for Svelte v3 and v4 at the same time. It also reverts the type changes in #112 so it matches that of Svelte v3.

This will be released as a patch version, and then shortly after #128 that pins to Svelte v4 will be released as a major, requiring any Svelte v4 users to upgrade this addon with the breaking change.

I've tested that this makes types work by installing this canary in a Svelte v3 project and see that it works, where the current latest release of this addon makes the types fail similar to #121.

📦 Published PR as canary version: 3.0.10--canary.127.893640b.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/addon-svelte-csf@3.0.10--canary.127.893640b.0 # or yarn add @storybook/addon-svelte-csf@3.0.10--canary.127.893640b.0 ```
socket-security[bot] commented 1 year ago

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
svelte-check 3.5.0 None +1 8.81 MB svelte-language-tools-deploy
shilman commented 1 year ago

:rocket: PR was released in v3.0.10 :rocket: