search

storybookjs / addon-svelte-csf

[Incubation] CSF using Svelte components.
MIT License
98 stars 29 forks source link

fix: move MetaProps to its own declaration to allow for overrides #138

Closed paoloricciuti closed 9 months ago

paoloricciuti commented 9 months ago

Right now the Meta class doesn't have a Props interface. This make it impossible to add overrides to the props (i'm using interface merging to provide intellisense for some parameters)

With this simple change the users will be able to augment the the typing of the Meta component

oscard0m commented 9 months ago

✅ but wait for @JReinhold's review

j3rem1e commented 9 months ago

FYI the Meta tag will be deprecated soon.

paoloricciuti commented 9 months ago

FYI the Meta tag will be deprecated soon.

Oh yeah I saw that discussion...well until then 😄 also this could help to keep the typing this way when the meta is moved to the module script

paoloricciuti commented 9 months ago

Do I need to do something else before merging?

shilman commented 9 months ago

:rocket: PR was released in v4.0.4 :rocket: