search

storybookjs / addon-svelte-csf

[Incubation] CSF using Svelte components.
MIT License
98 stars 29 forks source link

Update README.md #173

Closed LuisEGR closed 4 months ago

LuisEGR commented 4 months ago

Updated the Getting Started instruction number 3, this was quite confusing, initially says add "*.stories.svelte" which if taked literary, one can think of adding this string as a new element to the array, but after closing inspection (because it is not working), one can realize in the example the correct configuration, all this can be avoided if the instructions are clearer.

JReinhold commented 4 months ago

I see what you mean, but I think this proposal could be equally confusing. What about something like

  1. In .storybook/main.js, include .stories.svelte files in your stories patterns, eg. by changing the patterns to '../src/**/*.stories.@(js|jsx|ts|tsx|svelte)'
LuisEGR commented 4 months ago

I agree with you, I've just pushed another commit with that change.

shilman commented 4 months ago

:rocket: PR was released in v4.1.2 :rocket: