search

storybookjs / addon-svelte-csf

[Incubation] CSF using Svelte components.
MIT License
98 stars 29 forks source link

Experimental Svelte 5 Support #177

Closed tsar-boomba closed 1 month ago

tsar-boomba commented 2 months ago

Updates some dependencies:

Issues

  1. Collect stories test cannot pass even though the addon works fine in actual storybook
  2. Args to components cannot be inferred when using runes mdoe in a component. For example, in the ArgsTable story, you cannot tweak any of the props from the story ui.
xeho91 commented 2 months ago

Hi, this is just a heads up.

I've had a time to do some research with Storybook support for Svelte 5, including this addon.

While testing your PR, I've noticed that the stories in the group MetaExport doesn't work at runtime.

EDIT: @tsar-boomba I was motivated enough to try my luck, and I've got it partially working by aggressively dropping support for v4 and removing the deprecated features such as component Meta. The only issue left I have is with correct parsing the of few meta export key properties such as title to pass the tests.

I've branched out from your branch. I do not wish to interrupt your contribution, so I've added you to Discord (my username is xeho91). Please let's discuss how I can help you, and show you what I've done. Thanks!

xeho91 commented 2 months ago

There's my attempt: https://github.com/tsar-boomba/addon-svelte-csf/pull/1

Feel free to copy/cherry-pick/whatever, and let me know if I can help more with testing/contributing.

JReinhold commented 1 month ago

@xeho91 could you open a PR directly to this repo, so that we're not all blocked by each other?

Feel free to attribute relevant changes to @tsar-boomba

tsar-boomba commented 1 month ago

Closing in favor of #181