The core consolidation project will cause unresolved packages to start failing storybook.
This package has such unresolved dependencies.
Mind you this would have already broken pnp mode and possible other strict dependency managers.
So it's a thing we want to fix, even if the core package consolidation project is delayed or cancelled.
1 solution would be to move these to regular dependencies, instead of devDependencies.
But with the core package consolidation project in mind, removing/reducing the dependency on those packages is a good move.
What I did:
I updated some devDependencies, because why not?
I removed the need for @storybook/node-logger, I deemed it not important enough to keep.
I removed the use of @storybook/client-logger in the piece of code that's shared between server & browser.
The dependency on @storybook/node-logger was missing completely!
@storybook/client-logger was being referenced in a piece of code used by both node & browser.
This is fine for browser, because of prebundling (globalized in both preview & manager), but this is really bad for node, because:
the dependency is missing
it's loading browser code into node.
QA:
I've manually tested this by:
generating a svelte sandbox
changing the dependency version
installing
running build-storybook (was not working before this patch)
📦 Published PR as canary version: 4.1.3--canary.182.cb1f688.0
:sparkles: Test out this PR locally via:
```bash
npm install @storybook/addon-svelte-csf@4.1.3--canary.182.cb1f688.0
# or
yarn add @storybook/addon-svelte-csf@4.1.3--canary.182.cb1f688.0
```
shilman
commented
1 month ago
This fixes:
The core consolidation project will cause unresolved packages to start failing storybook. This package has such unresolved dependencies.
Mind you this would have already broken
pnpmode and possible other strict dependency managers. So it's a thing we want to fix, even if the core package consolidation project is delayed or cancelled.1 solution would be to move these to regular dependencies, instead of devDependencies. But with the core package consolidation project in mind, removing/reducing the dependency on those packages is a good move.
What I did:
@storybook/node-logger, I deemed it not important enough to keep.@storybook/client-loggerin the piece of code that's shared between server & browser.The dependency on
@storybook/node-loggerwas missing completely!@storybook/client-loggerwas being referenced in a piece of code used by both node & browser. This is fine for browser, because of prebundling (globalized in both preview & manager), but this is really bad for node, because:QA:
I've manually tested this by:
📦 Published PR as canary version:
4.1.3--canary.182.cb1f688.0:sparkles: Test out this PR locally via: ```bash npm install @storybook/addon-svelte-csf@4.1.3--canary.182.cb1f688.0 # or yarn add @storybook/addon-svelte-csf@4.1.3--canary.182.cb1f688.0 ```