search

storybookjs / addon-svelte-csf

[Incubation] CSF using Svelte components.
MIT License
103 stars 32 forks source link

chore: Remove `@storybook/types` dependency in favor of `storybook/types/internal` #205

Closed xeho91 closed 1 month ago

xeho91 commented 1 month ago
📦 Published PR as canary version: 4.1.7--canary.205.f0ef597.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/addon-svelte-csf@4.1.7--canary.205.f0ef597.0 # or yarn add @storybook/addon-svelte-csf@4.1.7--canary.205.f0ef597.0 ```

@JReinhold I need an opinion. We could update storybook and @storybook/* dependencies as drive-by to this PR. As far I managed to find out, this change (from @storybook/types to storybook/types/internal) was made in v8.2.

JReinhold commented 1 month ago

It shouldn't make a difference to users, storybook/internal was created in a way that ensures backwards compatibility with 8.0 and @storybook/types. I'd prefer to stay with @storybook/types to keep supporting Storybook 8.0. If we're facing any problems with @storybook/types or storybook/internal, we should fix that upstream instead, since that will probably also cause problems for other addons.

xeho91 commented 1 month ago

No objection, good points. Closing this PR then.