Add offset to keyboard-focused outlines

storybookjs / design-system

🗃 Storybook Design System

https://master--5ccbc373887ca40020446347.chromatic.com/

1.91k stars 585 forks source link

Add offset to keyboard-focused outlines #272

Open darleendenno opened 3 years ago

darleendenno commented 3 years ago

Description

The outline for keyboard-focused elements looks a little crowded. It was recommended in #271 to add an outline offset to improve visibility and streamline accessibility design.

Acceptance Criteria

All buttons that are keyboard-focused should have an outline offset
All links that are keyboard-focused should have an outline offset

domyen commented 3 years ago

I believe this is merged now

darleendenno commented 3 years ago

@domyen I don’t think so. We recently merged #271 but didn’t address this issue because it was out of scope.

darleendenno commented 3 years ago

There is a concern that adding an offset could disrupt current layouts. I think we should take an inventory when CSF 3.0 is released and we can snapshot these interactions.