search

storybookjs / design-system

🗃 Storybook Design System
https://master--5ccbc373887ca40020446347.chromatic.com/
1.91k stars 585 forks source link

emotion convertion #305

Closed ndelangen closed 2 years ago

ndelangen commented 3 years ago

@Andarist I made this PR to check if chromatic UI review will report 0 changes as well

📦 Published PR as canary version: 6.4.2-canary.305.ab1cc56.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/design-system@6.4.2-canary.305.ab1cc56.0 # or yarn add @storybook/design-system@6.4.2-canary.305.ab1cc56.0 ```
ndelangen commented 3 years ago

Overall, looks good! I'm confident we can proceed.

ndelangen commented 2 years ago

@kylegach @winkerVSbecks What's the process of releasing this as a new major version?

Is it easy for either of you to do?

Will merging this cause it the be released as a new major automatically?

kylegach commented 2 years ago

@kylegach @winkerVSbecks What's the process of releasing this as a new major version?

Is it easy for either of you to do?

Will merging this cause it the be released as a new major automatically?

I believe it's based on labels. I just added a "Major" label, so it should do the right thing when merged. Someone should confirm my understanding on that, though.

github-actions[bot] commented 2 years ago

:rocket: PR was released in v7.0.0 :rocket: