search

storybookjs / design-system

🗃 Storybook Design System
https://master--5ccbc373887ca40020446347.chromatic.com/
1.91k stars 585 forks source link

Pull AddonsSubheading from `frontpage` into the DS #311

Closed smithambera closed 2 years ago

smithambera commented 2 years ago

Fixes https://linear.app/chromaui/issue/CH-712/pull-addonssubheading-from-frontpage-into-ds

Description

Pulling the AddonsSubheading component from https://github.com/storybookjs/frontpage into the DS in preparation for future work.

Of Note

Following this proposal and branching off of the branch converting the DS to Emotion.

QA instructions

Confirm the styles (mostly) match the designs.

📦 Published PR as canary version: 6.4.2-canary.311.ead8442.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/design-system@6.4.2-canary.311.ead8442.0 # or yarn add @storybook/design-system@6.4.2-canary.311.ead8442.0 ```
domyen commented 2 years ago

hey @smithambera before I forget, I think this might have gotten lost:

Can we omit the letter-spacing on the muted state, it's an unintentional artifact from Figma (their inspect feature doesn't have ems)

smithambera commented 2 years ago

Hey @domyen! I've already merged this so I'll make a quick PR to remove that. Where did you make that comment? I don't see it anywhere ☹️

github-actions[bot] commented 2 years ago

:rocket: PR was released in v7.0.0 :rocket: