search

storybookjs / design-system

🗃 Storybook Design System
https://master--5ccbc373887ca40020446347.chromatic.com/
1.91k stars 585 forks source link

Remove props from Icon #315

Closed smithambera closed 2 years ago

smithambera commented 2 years ago

Fixes https://linear.app/chromaui/issue/CH-876/remove-color-prop-from-ds-icon

Description

Feedback from @domyen:

Our current ergonomics are to define styles outside of the component markup (i.e., in styled and not inline). It seems like we’re moving to that even more with the *.style.ts pattern I saw in one of your PRs. I don’t think the Icon should have a color prop because it’s a departure from these ergonomics.

As such, I removed the color prop. I also removed the block prop for the same reason - it didn't seem to be used anywhere anyway.

📦 Published PR as canary version: 6.4.2-canary.315.c122c5e.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/design-system@6.4.2-canary.315.c122c5e.0 # or yarn add @storybook/design-system@6.4.2-canary.315.c122c5e.0 ```
domyen commented 2 years ago

lgtm! merging

github-actions[bot] commented 2 years ago

:rocket: PR was released in v7.0.0 :rocket: