search

storybookjs / design-system

🗃 Storybook Design System
https://master--5ccbc373887ca40020446347.chromatic.com/
1.91k stars 585 forks source link

Update every icon (and add a few new ones) #364

Closed MichaelArestad closed 2 years ago

MichaelArestad commented 2 years ago
  1. Every icon has been redrawn at 14px x 14px.
  2. Several new/missing icons have been added.
  3. The Icon component has been rewritten to allow multiple paths.

Bonus: Icons.tsx (formerly icons.ts) went from 129,864 bytes to 68,898 bytes even though I added 20 additional icons.

📦 Published PR as canary version: 7.4.2-canary.364.5f00c3a.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/design-system@7.4.2-canary.364.5f00c3a.0 # or yarn add @storybook/design-system@7.4.2-canary.364.5f00c3a.0 ```
winkerVSbecks commented 2 years ago

@MichaelArestad pushed a minor update. Exporting the Icon props so that we can access it in other modules

ndelangen commented 2 years ago

Do you still need my review? Seems y'all have it pretty well covered tbh 😄

MichaelArestad commented 2 years ago

@ndelangen No thank you.

domyen commented 2 years ago

lgtm

github-actions[bot] commented 2 years ago

:rocket: PR was released in v7.5.0 :rocket: