search

storybookjs / design-system

🗃 Storybook Design System
https://master--5ccbc373887ca40020446347.chromatic.com/
1.91k stars 585 forks source link

Checkbox: checkboxColor is not actually required #365

Closed kylesuss closed 2 years ago

kylesuss commented 2 years ago

Our Checkbox component had some types that were actually conflicting with the current story args, but I noticed when importing it into another app that checkboxColor is a required prop when it shouldn't be.

The checkboxColor is inferred in the main component & passed down to an emotion component, where it is required. The main component inferred styles from the emotion component, hence the requirement, but I am choosing to omit the checkboxColor in the main component's styles now to avoid this issue.

github-actions[bot] commented 2 years ago

:rocket: PR was released in v7.6.1 :rocket: