search

storybookjs / design-system

🗃 Storybook Design System
https://master--5ccbc373887ca40020446347.chromatic.com/
1.92k stars 585 forks source link

update cardinal types #405

Closed thafryer closed 1 year ago

thafryer commented 1 year ago

While working in Chromatic, I started running into some issues using the Cardinal component in Typescript with emotion. The main piece of this PR is to type Cardinal as a FunctionComponent. Based on usage across repositories, I also went ahead and configured which props should be optional.

📦 Published PR as canary version: 7.12.3-canary.405.cde7bcd.0
:sparkles: Test out this PR locally via: ```bash npm install @storybook/design-system@7.12.3-canary.405.cde7bcd.0 # or yarn add @storybook/design-system@7.12.3-canary.405.cde7bcd.0 ```
github-actions[bot] commented 1 year ago

:rocket: PR was released in v7.12.3 :rocket: