search

storybookjs / design-system

🗃 Storybook Design System
https://master--5ccbc373887ca40020446347.chromatic.com/
1.91k stars 585 forks source link

Override WithTooltips default role of 'button' #422

Closed andrewortwein closed 1 year ago

andrewortwein commented 1 year ago

The Input component contains an ErrorTooltip wrapper (an instance of WithTooltip). That wrapper, by default, has an aria role of 'button'. It's very strange for an input field to have a button role and it is causing problems with iOS VoiceControl, where selecting that field does not show the on-screen keyboard.

With this change, the role will be overriden to 'none', allowing the keyboard to show.

github-actions[bot] commented 1 year ago

:rocket: PR was released in v7.15.13 :rocket: