fix(no-uninstalled-addons) Support Windows paths - Githubissues

storybookjs / eslint-plugin-storybook

🎗Official ESLint plugin for Storybook

MIT License

238 stars 42 forks source link

fix(no-uninstalled-addons) Support Windows paths #112

Closed Dschungelabenteuer closed 1 year ago

Dschungelabenteuer commented 1 year ago

What Changed

Running the tests fails on Windows because of the way paths are being resolved inside the no-uninstalled-addons rule.

Replaced the relevant / occurrences with path.sep which should just work for both POSIX and Windows.
Updated the tests accordingly.

Checklist

Check the ones applicable to your change:

[X] Ran yarn update-all
[X] Tests are updated
[ ] Documentation is updated

Change Type

Indicate the type of change your pull request is:

[ ] maintenance
[ ] documentation
[X] patch
[ ] minor
[ ] major

yannbf commented 1 year ago

This is great, thanks for your contribution @Dschungelabenteuer !!

github-actions[bot] commented 1 year ago

:rocket: PR was released in v0.6.9 :rocket: